# Fix LINT and Style issues
# Add more unit test
# Add defer_run_immediately support in the CLI command
# Change the command from supply-chain task to supply-chain workflow - Need to read document
# Change the show command to display cadence as "n"d instead of cron expression, order the list by name
# Check if Resource_group is coming as mandatory field Or it can be set in the config and can be fetched directly from there

remove redundant files

Fix formatting
Fix bugs

breaking test cases

…azure-cli-extensions into users/puwalech/acrcssc

upload of dry-run quick task should be done from temp folder
improve logging feedback
Increase time for MI setup
Make cadence and config file updates optional

…azure-cli-extensions into users/puwalech/acrcssc

help file
default values in documentation
test invalid json values

regex for days validation
change error messages
refactor code
fix test cases related to refactoring

…azure-cli-extensions into users/puwalech/acrcssc

…e calling list command + enhance log message (#32)

This PR adds a check to ensure that the cssc tasks exist before calling
the list command. It also displays that the list command is executed for
the last n days. Updated tests as well.

With this, below 2 bugs are addressed:
1.
https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694510/?view=edit
Before Fix: 

![image](https://github.com/user-attachments/assets/61ced20f-d8c4-42d6-bc8d-67e3ae299ed1)
After Fix:

![image](https://github.com/user-attachments/assets/807745a3-71f5-471c-89b5-62161fbd3fd1)

2.
https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694600/?view=edit
After Fix: added a line to indicate list executed for last n days:

![image](https://github.com/user-attachments/assets/fe832467-d337-4f18-a2c7-f713452e5c3a)

---------

Co-authored-by: Ruchi Maheshwari <rumahe@microsoft.com>

…iately options are mutually exclusive (#33)

Added validation to ensure that the `--dryrun` and `--run-immediately`
options cannot be used together both during create and update.
Also added unit tests for this scenario to ensure the validation works
as expected.

Bug -
https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694592/?view=edit

After fix:

![image](https://github.com/user-attachments/assets/b5a2f868-8904-42ea-aa9e-acb561943d2f)

Co-authored-by: Ruchi Maheshwari <rumahe@microsoft.com>

…mage fix bug (#35)

Updated the cssc image to latest to conclude on the duplicate image fix
bug -
https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31695069/?view=edit

---------

Co-authored-by: Ruchi Maheshwari <rumahe@microsoft.com>
Co-authored-by: Cesar Gray Blanco <cegraybl@microsoft.com>

To retrieve task logs class `WorkflowTaskStatus` uses a Poller to wait
for a task run to finish before attempting to download the logs. This is
only done during image limit check or when the `--dry-run` option is
used during the `create` and `update` commands. Since this is a remote
call there is a chance that we never get a response.

This PR adds a 10-minute timeout to the Poller. In case the timeout is
reached, the required message is logged, and the attempt will be done to
retrieve the logs if there are any to allow the operation to continue.

In case of a timeout during `create` or `update` the command will not
block in case the image limit check could not be performed, to allow for
a better user experience. In case the image limit is reached, the user
will be informed via the trigger task that will perform the check every
time it runs.

…l any running scan or patch task (#34)

This change allows the 'delete' command to check and prompt to cancel
any running scan or patch task before deleting the workflow. the
operation will not prompt id used with the parameter `--yes|-y` and
accepts `--dryrun` which will run the command without executing the
cancellation of the tasks.
Includes small fixes for style and lint issues.


![image](https://github.com/user-attachments/assets/2d14adf6-617c-4aae-b177-45db995fbd93)

…ner Registry Tasks Contributor' (#38)

Change role assignment during deployment from 'Contributor' to
'Container Registry Tasks Contributor' to trigger and scan tasks during
deployment. Reduce access given to the CSSC tasks.

For the new role assignment to take effect the tasks have to be
redeployed.

#39)

This change is only to add check for empty token.
A following PR will be made to update the oras package. Since there are
substantial changes to the client usage.

Adding a centralized check for every token we retrieve from the registry
and improve on error logging

Fix filtering on the `list` command by `--run-status` to make it correct
once again.
Now the `--run-status` will filter the image status depending on the
final status of both the scan and patch instead of only one of them.
Meaning that for an image to be marked as `FAILED` scan or patch have to
be `FAILED`, for an image to be marked as `SUCCEEDED` both scan and
patch have to be `SUCCEEDED` or `SKIPPED` as that is treated as a
successful execution, and for an image to be marked as `SKIPPED` the
scan has to be `SUCCEEDED` and the patch has to be `SKIPPED`.

This PR also includes a unit test to catch issues with the filtering.

In addition, includes fixes for unit tests that are run without azure
credentials, adding the required mocks to avoid that dependency.

…41)

This change is a continuation of the changes in [PR
39](#39)
Updates the `oras` packages to 0.2.25 to use a more recent version of
the package to avoid the "empty token" error when authenticating to the
registry.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This change addresses all the comments in the [public repo
PR](Azure#8530).
Final change for public preview.
Test passes, lint and style are successful.

…it) (#44)

This change addresses all the comments in the official repo
Final change for public preview.
Test passes, lint and style are successful.

…45)

critical items found during bug bash
To fail faster and avoid creating a task without configuration the
extension has to push the configuration before attempting to deploy

…15 (#46)

Address a partial list of PR comments on the public PR:
Azure#8530
Rest of comments require additional consideration.

…16 (#47)

Second wave of PR comments for
Azure#8530
Fix remaining open comments on public PR until 04/16/25
Test, style and linter are clean

…422 (#48)

Third wave of PR comments for
Azure#8530
Fix remaining open comments on public PR until 04/22/25
Test, style and linter are clean

- remove unused recording
- remove phony secrets from test live recording to avoid flagging

- fix test_acr_cssc_dry_run test, mock required dependency
- add header to test file
- run azdev mask' with LOW to mask anything missing

…r update and --run-status under list parameters